Answer
Yes, Benni McCarthy is the all-time top scorer for the South Africa national team. He has scored 31 goals for his country, which is more than any other player. McCarthy played for South Africa from 1997 to 2010, and he helped them to reach the quarterfinals of the 2002 World Cup. He is considered to be one of the greatest South African footballers of all time.